search

djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

Toggle embedded images/videos #140

Open ledbettj opened 10 years ago

ledbettj commented 10 years ago

Embedded content (images, videos) needs an associated button/link to click to toggle the inline content.

It can be quite distracting to have an animated gif playing over and over.

AlexKvazos commented 10 years ago

It is possible to toggle them. Settings panel can be opened using the cogs button on the bottom left corner of the window.

AlexKvazos commented 10 years ago

What you meant is a button to toggle the content once it is already inserted inline? Or the above response solves your question?

ledbettj commented 10 years ago

What you meant is a button to toggle the content once it is already inserted inline? Or the above response solves your question?

Yes, this -- similar to the gist embedding functionality or the same functionality in HipChat:

screen shot 2014-06-27 at 9 41 35 am

Sorry for the confusion.

xqwzts commented 10 years ago

Good idea, we'd basically need to wrap the embeds in the ShowMore partial the way the gist embed currently does.

cvespa commented 10 years ago

@AlexKvazos @xqwzts i am already working on this for images and im making it so it can be used for all embeds

noncetonic commented 9 years ago

Any update on this? It'd also be nice if the image isn't shown until after the button is toggled. Automatically fetching images could lead to users inadvertently leaking their IP addresses to malicious attackers that know Komanda automatically fetches images.