search

djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

Fullscreen toggle #145

Closed AlexKvazos closed 10 years ago

AlexKvazos commented 10 years ago

Hey there!

I was wondering how come the client didn't have a full screen button. Not sure if it was intended or forgotten, but here is the PR in case you guys do want it. The feature is as simple as it sounds.

enter image description here

Top-Right Corner - Shows the full screen toggle button on its normal state

enter image description here

Top-Right Corner - Shows the full screen toggle button on its hover state

enter image description here

Komanda running full screen on a 1080p monitor with the mouse touching the top corner to display the OS X tool bar

Functionality has only been tested on OS X. It is suggested that it is checked on Windows and Linux before merging this PR.

Cheers!

jeffpamer commented 10 years ago

Nice work, I'd been waiting for this. One thing though, I know it's very small in the grand scheme of things, but it's really bothering me that the icon isn't vertically centered.

AlexKvazos commented 10 years ago

@jeffpamer fixed, https://github.com/mephux/komanda/pull/148 just waiting for merge