djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

Big cleanup + small bugfix #180

Closed Alex-D closed 10 years ago

Alex-D commented 10 years ago

This is a big cleanup in komanda and icons styles files (see #179)

Be carefull before merge this branch, you need to test each feature tu check if I don't have deleted a usefull line.

I develop on Windows, I have make a little change on the package.json because this not work with the relative path.

This PR should fix #176

rahatarmanahmed commented 10 years ago

It seems to be mostly okay. The only glaring issue is the github buttons: new

You're missing background-image: -webkit-gradient( linear, left top, left bottom, from(#d5d6d9), to(#afb0b7)); under .plugin-button.

Also the postinstall script was changed to require bower be installed globally. It's probably best to update the README to illustrate this.

Out of curiosity, what tool did you use to clean this up? (If you did it by hand... wow)

Alex-D commented 10 years ago

If you did it by hand... wow

By hand, it's the best tool :)

background-image: -webkit-gradient

This is so strange : http://caniuse.com/#search=gradient Chrome (so Blink) does not require -webkit- prefix :/

rahatarmanahmed commented 10 years ago

Sorry, use the regular gradient. I just meant it was missing a gradient of any kind. On Jul 28, 2014 5:07 PM, "Alexandre Demode" notifications@github.com wrote:

If you did it by hand... wow

By hand, it's the best tool :)

background-image: -webkit-gradient

This is so strange : http://caniuse.com/#search=gradient Chrome (so Blink) does not require -webkit- prefix :/

— Reply to this email directly or view it on GitHub https://github.com/mephux/komanda/pull/180#issuecomment-50409143.

Alex-D commented 10 years ago

I've fix mistake and I've rebase to make this PR mergeable.

Alex-D commented 10 years ago

Anyone can check my PR ? I don't want to rebase my PR each 5 minutes :(

So please check it, then I rebase and finaly you merge before merge any other PR. Or you merge by hand and resolve conflicts yourself :/