search

djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

version up node-webkit #191

Closed Constellation closed 10 years ago

Constellation commented 10 years ago

And use the latest grunt-node-webkit-builder

tyscorp commented 10 years ago

Does this need any changes to http://komanda.io/nw stuff?

Constellation commented 10 years ago

@tyscorp: It downloads node-webkit from the official distribution, http://dl.node-webkit.org/. (by node-webkit-builder) So http://komanda.io/nw is not used.

djcas9 commented 10 years ago

@Constellation we are using custom node-webkit builds for windows and macosx so we can do native notifications, icon badge labels and other stuff - this will break all of that. What does 0.10.1 add thats worth upgrading for?

Constellation commented 10 years ago

@mephux:

we are using custom node-webkit builds for windows and macosx so we can do native notifications, icon badge labels and other stuff - this will break all of that. What does 0.10.1 add thats worth upgrading for?

Oh, I don't know that. Is there the patch / repository of the custom node-webkit? Some features, such as Notification and badge is now supported by official node-webkit (0.10.1). https://github.com/rogerwang/node-webkit/pull/1709 https://github.com/rogerwang/node-webkit/pull/1957 https://github.com/rogerwang/node-webkit/pull/1951 And #193 depends on node-webkit 0.10.1.

djcas9 commented 10 years ago

@Constellation that looks like everything we need - i'll try it out tonight and see how it works out.

Constellation commented 10 years ago

Slightly updated with thje missed cache directory changes.

eugene-bulkin commented 10 years ago

@mephux is this ready to merge yet?

tyscorp commented 10 years ago

I just tested this on Windows. Everything seems to be fine.