search

djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

Don't scroll to bottom on entering channel #203

Open ahmadsoe opened 10 years ago

ahmadsoe commented 10 years ago

When entering on channel with a lot of new messages, we lost the last reading position because scroll bar go to the bottom. This commit will fix that problem.

djcas9 commented 10 years ago

@ahmadsoe can you explain a little more about that the problem is or why this behavior is not ideal. I just want to understand a bit better before i merge. Thank you.

djcas9 commented 10 years ago

@ahmadsoe ops, nvm - didn't notice your description.

djcas9 commented 10 years ago

@ahmadsoe so, the issue is ZNC/bounce buffer playback vs a normal irc connection. On a znc session this will force the user to scroll to the bottom manually. Does anyone have any thoughts on a solution.

ghost commented 10 years ago

I don't like the idea of having to manually scroll down. What about an option to enable/disable this in the settings?

djcas9 commented 10 years ago

@KindOne- would be odd to have a one off option for something like that.. i need to see if there is a way to detect bounce buffer playback.

ahmadsoe commented 10 years ago

On a znc session, have they read all of the buffer messages before entering a channel?.. I think that if you follow a conversation, you need to read it in the right order from last message you have read and go to the newer message..

But If you won't read them all and just go to the bottom, maybe keyboard shortcut and/or 'scroll to the bottom' button can be a simple solution.

00z commented 10 years ago

Actually I only care about the message for me and just skip other conversations, so I prefer the 'scroll to bottom ' option.

kumpelblase2 commented 10 years ago

I guess it's really up to the users preference if he likes to read the whole conversation every time or just when he really wants to. I can see why people would like it to scroll to the bottom or why it shouldn't.

I would be in favor of either a setting that you can check/uncheck or a keyboard shortcut to scroll to top or bottom. Maybe it would be a good idea to "outsource" it to a plugin in a way, so people who really dislike it could just disable/remove it?

00z commented 10 years ago

＠kumpelblase2, I agree with that!