djcas9 / komanda

The IRC Client For Developers
http://komanda.io
MIT License
1.78k stars 75 forks source link

Fix specifying build targets #210

Closed 0xazure closed 10 years ago

0xazure commented 10 years ago

Hi all.

Gave grunt build another tweak because it looks like 6bda2e0ec844057ef2b2ae625b33b9d3a0c82166 unintentionally borked how the build task was determining which platforms to build, so it just defaulted to building all of them as initially defined in the nodewebkit.options object.

Specifically, Gruntfile.js#L216 where the nodewebkit task now takes an array of platforms instead of using a series of keys like it used to is what threw everything off.

Also, curiously, the nodewebkit task no longer understands 'mac' and now only understands 'osx', so I threw in some logic in the build task to handle that. I did have to change the commands for grunt exec:createDmg and grunt shell:create_dmg because they use the path to the OS X build, so if someone who can run those tasks can test them for me? ./dist/ is in the .gitignore and not part of the project. I was hesitant to change too much in regards to the mac/osx discrepancy, but I can go back through and change everything else over if it's desired.

Cheers.