search

djcb / mu

maildir indexer/searcher + emacs mail client + guile bindings
http://www.djcbsoftware.nl/code/mu
GNU General Public License v3.0
1.6k stars 385 forks source link

Calendar invite stopped working #2666

Closed joukeHijlkema closed 5 months ago

joukeHijlkema commented 5 months ago

Describe the bug Emails with a calendar invite give the error when clicking on Accept. This worked until I upgraded to the latest version (1.12.0)

Debugger entered--Lisp error: (error "This is a pseudo-article") signal(error ("This is a pseudo-article")) error("This is a pseudo-article") gnus-summary-select-article() gnus-summary-reply() gnus-icalendar-send-buffer-by-mail("*CAL*" "Accepted: Lunar Islands - Discussion on Test Defin..." "xxx.xxx@xxx.xx") gnus-icalendar-reply(((#<buffer *mm*-736088> ("text/calendar" (method . "REQUEST") (charset . "utf-8")) base64 nil nil nil nil nil) accepted #<gnus-icalendar-event-request gnus-icalendar-event-request-17a852db3894>)) gnus-article-push-button((mouse-2 (#<window 13 on *mu4e-article*> 761 (53 . 355) 849592659 nil 761 (6 . 19) nil (5 . 10) (8 . 18)))) funcall-interactively(gnus-article-push-button (mouse-2 (#<window 13 on *mu4e-article*> 761 (53 . 355) 849592659 nil 761 (6 . 19) nil (5 . 10) (8 . 18)))) call-interactively(gnus-article-push-button nil nil) command-execute(gnus-article-push-button) How to Reproduce open an email with an inviter and click [Accept] error.txt

Environment

Checklist

Please make sure you all items in the checklist are set/met before filing the ticket. Thank you!

djcb commented 5 months ago

Does this happen with all invitation or only some? And do the ones failing still work with 1.10?

djcb commented 5 months ago

@Chris00 any idea?

joukeHijlkema commented 5 months ago

I'll check asap.

On Mon, 18 Mar 2024, 21:26 Dirk-Jan C. Binnema, @.***> wrote:

@Chris00 https://github.com/Chris00 any idea?

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2004915737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADC3WVXK4SZJWCIDWIUATDYY5EYJAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUHEYTKNZTG4 . You are receiving this because you authored the thread.Message ID: @.***>

Chris00 commented 5 months ago

As coincidence has it, I replied to an invitation today (with mu commit 0b68afe9) and it went fine. A specific message would be helpful.

joukeHijlkema commented 5 months ago

I uploaded one with the bug report.

On Mon, 18 Mar 2024, 23:13 Christophe Troestler, @.***> wrote:

As coincidence has it, I replied to an invitation today (with mu commit 0b68afe https://github.com/djcb/mu/commit/0b68afe9aaf2885978af9c1912dc03265b60ad84) and it went fine. A specific message would be helpful.

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2005137754, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADC3WSVQBD2MZ6SN2UEP7TYY5RJLAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGEZTONZVGQ . You are receiving this because you authored the thread.Message ID: @.***>

Chris00 commented 5 months ago

Ah, I got mistaken with the name of the file and text around it. As I was not in the liste I got an “Uninvited Accept” but I could replay to it without problem — you (or theodor) should have received the message.

joukeHijlkema commented 5 months ago

I checked and for me it bugs with other invites as well. I went back to 1.10.8 and it still won't work so maybe it is something on my side eventhough I don't think I touched anything. I'll make a clean init file this as soon as I have some time to test. Will keep you posted.

Jouke

On Mon, Mar 18, 2024 at 11:50 PM Christophe Troestler < @.***> wrote:

Ah, I got mistaken with the name of the file and text around it. As I was not in the liste I got an “Uninvited Accept” but I could replay to it without problem — you (or theodor) should have received the message.

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2005194564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADC3WR4TUMJFEGU4O4FTNTYY5VRZAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGE4TINJWGQ . You are receiving this because you authored the thread.Message ID: @.***>

joukeHijlkema commented 5 months ago

Just found this in my warnings: Error (use-package): mu4e/:init: Symbol’s function definition is void: mu4e-icalendar-setup

This is in my init file: (use-package mu4e :straight (:host github :files ("build/mu4e/*.el") :repo "djcb/mu" :branch "release/1.10" :pre-build (("./autogen.sh") ("/usr/bin/meson" "setup" "--reconfigure" "build") (shell-command (concat "echo " (shell-quote-argument (read-passwd "root password? ")) " | sudo -S /usr/bin/ninja -C build install")))) :commands mu4e :config (message "=== my mu4e config ===") (setq mail-user-agent 'mu4e-user-agent) (setq mu4e-get-mail-command "/usr/bin/offlineimap -o") (setq mu4e-sent-folder "/Work/INBOX.Sent") (setq mu4e-mu-binary "/usr/local/bin/mu")

(mu4e-bookmark-define "maildir:/Work/INBOX NOT flag:trashed" "Inbox" ?i) (mu4e-bookmark-define "maildir:/Work/INBOX AND flag:unread" "Inbox unread" ?u) (mu4e-bookmark-define "maildir:/Work/INBOX.Sent" "Sent" ?s) (mu4e-bookmark-define "maildir:/Work/INBOX AND date:today..now AND NOT flag:trashed" "Today" ?t) (mu4e-bookmark-define "maildir:/Work/INBOX AND date:1w..now AND NOT flag:trashed" "Last week" ?w) (mu4e-bookmark-define "maildir:/Work/INBOX AND date:5w..now AND NOT flag:trashed" "Last month" ?m) (mu4e-bookmark-define "maildir:/Spam AND flag:unread" "Spam" ?z)

(setq message-send-mail-function 'smtpmail-send-it smtpmail-default-smtp-server "imap-mip.onecert.fr" smtpmail-smtp-server "imap-mip.onecert.fr" smtp-local-domain "onera.fr")

;; Calendar events (setq mu4e-icalendar-diary-file "/home/hylkema/Documents/Org/Calendar/Test.org") (mu4e-icalendar-setup) (setq gnus-icalendar-org-capture-file "/home/hylkema/Documents/Org/Calendar/Test.org") (setq gnus-icalendar-org-capture-headline '("Calendar")) (gnus-icalendar-org-setup) )

On Tue, Mar 19, 2024 at 10:40 AM jouke hijlkema @.***> wrote:

I checked and for me it bugs with other invites as well. I went back to 1.10.8 and it still won't work so maybe it is something on my side eventhough I don't think I touched anything. I'll make a clean init file this as soon as I have some time to test. Will keep you posted.

Jouke

On Mon, Mar 18, 2024 at 11:50 PM Christophe Troestler < @.***> wrote:

Ah, I got mistaken with the name of the file and text around it. As I was not in the liste I got an “Uninvited Accept” but I could replay to it without problem — you (or theodor) should have received the message.

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2005194564, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADC3WR4TUMJFEGU4O4FTNTYY5VRZAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVGE4TINJWGQ . You are receiving this because you authored the thread.Message ID: @.***>

Chris00 commented 5 months ago

You are correct, mu4e-icalendar-setup is in mu4e-obsolete.el but the instructions were not updated. You should use (gnus-icalendar-setup).

joukeHijlkema commented 5 months ago

Debugger entered--Lisp error: (void-function gnus-icalendar-setup) (gnus-icalendar-setup)

On Tue, Mar 19, 2024 at 11:21 AM Christophe Troestler < @.***> wrote:

You are correct, mu4e-icalendar-setup is in mu4e-obsolete.el https://github.com/djcb/mu/blob/master/mu4e/mu4e-obsolete.el#L273 but the instructions were not updated. You should use (gnus-icalendar-setup).

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2006706573, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADC3WX66ENFLPNW77FNRSTYZAGTHAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWG4YDMNJXGM . You are receiving this because you authored the thread.Message ID: @.***>

Chris00 commented 5 months ago

Did you do (require 'mu4e-icalendar) first?

On 19 March 2024 at 11:43 +01, jouke hijlkema @.***> wrote:

Debugger entered--Lisp error: (void-function gnus-icalendar-setup) (gnus-icalendar-setup)

On Tue, Mar 19, 2024 at 11:21 AM Christophe Troestler < @.***> wrote:

You are correct, mu4e-icalendar-setup is in mu4e-obsolete.el https://github.com/djcb/mu/blob/master/mu4e/mu4e-obsolete.el#L273 but the instructions were not updated. You should use (gnus-icalendar-setup).

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2006706573, or unsubscribe

https://github.com/notifications/unsubscribe-auth/AADC3WX66ENFLPNW77FNRSTYZAGTHAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWG4YDMNJXGM

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

joukeHijlkema commented 5 months ago

I do feel stupid now .... It works, thanks.

On Tue, Mar 19, 2024 at 11:48 AM Christophe Troestler < @.***> wrote:

Did you do (require 'mu4e-icalendar) first?

On 19 March 2024 at 11:43 +01, jouke hijlkema @.***> wrote:

Debugger entered--Lisp error: (void-function gnus-icalendar-setup) (gnus-icalendar-setup)

On Tue, Mar 19, 2024 at 11:21 AM Christophe Troestler < @.***> wrote:

You are correct, mu4e-icalendar-setup is in mu4e-obsolete.el https://github.com/djcb/mu/blob/master/mu4e/mu4e-obsolete.el#L273 but the instructions were not updated. You should use (gnus-icalendar-setup).

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2006706573, or unsubscribe

< https://github.com/notifications/unsubscribe-auth/AADC3WX66ENFLPNW77FNRSTYZAGTHAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWG4YDMNJXGM>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

— Reply to this email directly, view it on GitHub https://github.com/djcb/mu/issues/2666#issuecomment-2006803424, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADC3WSC5TVPMN4I6YCWPITYZAJXZAVCNFSM6AAAAABE3T67WWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBWHAYDGNBSGQ . You are receiving this because you authored the thread.Message ID: @.***>

djcb commented 5 months ago

Thanks, the instruction have been updated. I also added an alias for mu4e-icalendar-setup.

averter commented 4 months ago

hmmm... I'm experiencing a strange and possibly related issue. I'm able to export an invitation to org normally via the export to org button, but when I click any of the accept/tentative/decline buttons the template message that is created is different than what it used to be before 1.12.x. (example below). The subject is Re:none instead of the original message subject, and the in-reply-to field is now nobody's message of "(unknown date)" which is different than what it used to be... 

To: Recipient@myworkplaceemail.com
Subject: Re: none
From: My username <myusername@myworkplaceemail.com>
Date: Fri, 12 Apr 2024 13:39:38 +0100
Message-ID: <87cyqu21rp.fsf@myworkplaceemail.com>
In-Reply-To: nobody's message of "(unknown date)"
--text follows this line--
<#multipart type=alternative>
<#part type="text/plain">
<#/part>
<#part type="text/calendar; method=REPLY; charset=UTF-8" buffer="*CAL*">
<#/part>
<#/multipart>

My init.el contains simply

    ;; Use gnus article view
    (require 'mu4e-icalendar)
    (mu4e-icalendar-setup)
    (setq mu4e-icalendar-diary-file "~/.diary") ;new

    (require 'org-agenda)
    (setq gnus-icalendar-org-capture-file "~/org/NOTES.org")
    (setq gnus-icalendar-org-capture-headline '("Calendar"))
    (gnus-icalendar-org-setup)
djcb commented 4 months ago

@averter: can you share the raw message you received? (anonymize as needed of course, as long as it still reproduces.. thanks!)

djcb commented 4 months ago

Oh, and I did a small change (master)... does that help?

averter commented 4 months ago

@averter: can you share the raw message you received? (anonymize as needed of course, as long as it still reproduces.. thanks!)

raw_message.zip

averter commented 4 months ago

Oh, and I did a small change (master)... does that help?

Aha, indeed it does!

averter commented 4 months ago

@djcb I've noticed two things worth reporting.

  1. Unlike regular replies, clicking the buttons does not update the mu4e-context, and so one could by mistake reply accept/decline/tentative with the incorrect email address
  2. The reply email ends up in a separate email thread than the one from which the invitation message, and it does not include accept, decline, tentative in the subject.

Let me know if any of the above is not reproducible. Thanks.