mu4e--compose-setup-completion is disabling message-completion-function unconditionaly

[thierryvolpiatto]

Describe the bug

As a result when mu4e-compose-complete-addresses is nil we have no completion at all. The only solution is to reenable the hook from mu4e-compose-mode-hook.

I think what is needed is this:

diff --git a/mu4e/mu4e-compose.el b/mu4e/mu4e-compose.el
index 3b458c5f..eea48ba1 100644
--- a/mu4e/mu4e-compose.el
+++ b/mu4e/mu4e-compose.el
@@ -391,10 +391,10 @@ contact fields."

 (defun mu4e--compose-setup-completion ()
   "Set up auto-completion of addresses if enabled."
-  ;; turn off message-mode's completion, it's just interfering.
-  (remove-hook 'completion-at-point-functions
-               #'message-completion-function 'local)
   (when mu4e-compose-complete-addresses
+    ;; turn off message-mode's completion, it's just interfering.
+    (remove-hook 'completion-at-point-functions
+                 #'message-completion-function 'local)
     (set (make-local-variable 'completion-ignore-case) t)
     (set (make-local-variable 'completion-cycle-threshold) 7)
     (add-to-list (make-local-variable 'completion-styles) 'substring)

Environment

Please describe the versions of OS, Emacs, mu/mu4e etc. you are using.

LinuxMint and Emacs-29.3

Checklist

• [X ] you are running either an 1.10.x/1.12.x release or master (otherwise please upgrade)
• [ X] you can reproduce the problem without 3rd party extensions (including Doom/Evil, various extensions etc.)
• [ X] you have read all of the above

Please make sure you all items in the checklist are set/met before filing the ticket.

Thank you!

[djcb]

Thanks, I've reworked it a little bit, just making sure mu4e's completion is at the beginning (when enabled). Seems to work fine.

[thierryvolpiatto]

"Dirk-Jan C. Binnema" @.***> writes:

1. ( ) text/plain (*) text/html

Thanks, I've reworked it a little bit, just making sure mu4e's completion is at the beginning (when enabled).

Looks good thanks.

-- Thierry