djchung / ImageSearch

0 stars 0 forks source link

[Android Bootcamp: ImageSearch] Review my app #1

Open djchung opened 10 years ago

djchung commented 10 years ago

Completed the required user stores. /cc @nesquena

six hours to completed

djchung commented 10 years ago

found an issue that's stumping me:

I search, then scroll down as far as I can go, until it hits the bottom of the screen and can't scroll anymore. Then, if I search again, only the first page of results show and endless scroll is broken. @nesquena - can you point me in the right direction?

nesquena commented 10 years ago

In short, it has to do with the exception that's thrown on the 9th page of results. Easiest fix is to prevent the 9th request from being issued to avoid the issue in which the exception throws off the endless paging logic. Please confirm if you fix.

nesquena commented 10 years ago

:+1: nice work DJ. A few notes after checking out the code:

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.