djcooke / compendium

FFXIV Deep Dungeon Compendium
https://ddcompendium.com
11 stars 10 forks source link

Layout Improvements #64

Closed GitPaulo closed 9 months ago

GitPaulo commented 9 months ago

The idea is to make the layout a bit better and more understandable to un-versed users:

Preview

image

Search Idea

Can be scrapped if you think there's no use for it 🤔

https://github.com/djcooke/compendium/assets/18451329/c4e1fb63-4b3f-4475-80fd-f9744221c73d

GitPaulo commented 9 months ago

@djcooke let me know if this is something you like and I'll continue. ❤️

djcooke commented 9 months ago

Sorry, I'll get to reviewing this on the weekend. In the future, if you make separate PRs for separate features/changes, that would make reviewing simpler and merging cleaner. I appreciate the ideas and enthusiasm though!

GitPaulo commented 9 months ago

Sorry, I'll get to reviewing this on the weekend. In the future, if you make separate PRs for separate features/changes, that would make reviewing simpler and merging cleaner. I appreciate the ideas and enthusiasm though!

No rush, review whenever really! This stuff is mostly me throwing out ideas, feel free to reject stuff. I'll keep things more atomic in the future for sure 👍

djcooke commented 9 months ago

I haven't looked through the diff entirely, but initial thoughts:

Moved pomanders into knowledge to not clutter sidebar and I think it makes sense?

It makes sense, but I'd rather keep it separate so the pages are shorter. It is not a huge menu, so I don't think there's a need to reduce it.

Improved navigation styles, logo, etc.

Relying more on flexbox here and there

I haven't looked at this yet, but probably good

Minor updates to things (.gitignore, ...)

Thank you for adding a helpful readme. It's terrible that I have not done this myself. 😅

Implemented a search functionality (kind of)

GitPaulo commented 9 months ago

@djcooke I tried to implement most of the things you brought up.

LMK what you think 😎


I still kept pomanders in knowledge because, with the search and anchors, i don't see a reason to fear long pages? Still can be changed!I just favour small navbars.

GitPaulo commented 9 months ago

Is there a benefit to using flexbox here? It is causing issues.

Flexbox is just much easier to use, without breaking (much) stuff, when you've got the setup you have. I'll sort out the issues 👍

  • The menu tooltips look awkward. You make a good point that showing the full dungeon names would be better though. I think the ideal improvement would be to remove the extra left margins, increase the menu width a bit as necessary and use the full dungeon names instead of initials

Tooltips don't really make it any worse and add information to what's there IMO. I'll try the full names.

GitPaulo commented 9 months ago

@djcooke I've got a pretty good idea of what you like/don't like. I'll be splitting these changes into small PRs now and going to close this one.

This PR was me just fucking around really. It's a pain for you to review, let's change that.