Nibbler not working with Castling

dje-dev / Ceres

Ceres - an MCTS chess engine for research and recreation

GNU General Public License v3.0

153 stars 23 forks source link

Closed eahova closed 3 years ago

eahova commented 3 years ago

Fix #15 did fix the UCI eval calls but Nibbler still does not work with Castling.

Seemingly, it both does not return any moves that involve Castling and also crashes the engine if you do Castle.

Example fen: r1bqkb1r/ppp3p1/2n2p2/3p1n1p/3P4/2P2N1P/PP1NBPP1/R1BQK2R w KQkq - 2 9

In Ceres.exe UCI it returns bestmove e1g1 In Nibbler it shows top move of Qb3

After you castle with White is crashes the engine...

rooklift commented 3 years ago

Some of this might be on Nibbler's end but I can't really test things until there's a release.

eahova commented 3 years ago

Looks like Nibbler changes the KQkq into chess960 notation of AHah which isn't supported by Ceres

I added a pull request #21 to at least support the regular chess position of AHah so Nibbler works as you'd expect

rooklift commented 3 years ago

The logic in #21 is wrong, the correct equivalences are:

A --> Q
H --> K
a --> q
h --> k

The point is the letter in C960 format indicates where the target rook is.

eahova commented 3 years ago

@fohristiwhirl - thanks for catching...sorry about that...I put in pull request #22 to correct

dje-dev commented 3 years ago

Fixed with #22