djeck1432 / spotnet

8 stars 52 forks source link

Implement endpoint for subscription #197

Closed Michaelkingsdev closed 1 week ago

Michaelkingsdev commented 1 week ago

194 Draft

@djeck1432 This is just a draft PR. The endpoint creation is still in progress. I will update the db/crud.py too. I will re-run my pylint.

djeck1432 commented 1 week ago

@Michaelkingsdev You don't need to update crud for this issue

Michaelkingsdev commented 1 week ago

@Michaelkingsdev You don't need to update crud for this issue

Alright ser

djeck1432 commented 1 week ago

@Michaelkingsdev Please, fix tests and and also pylint issues

djeck1432 commented 1 week ago

@Michaelkingsdev any updates?

djeck1432 commented 1 week ago

@Michaelkingsdev if you don't have any updates next 5-6 hours, you will be unassigned

Michaelkingsdev commented 1 week ago

@Michaelkingsdev if you don't have any updates next 5-6 hours, you will be unassigned

Will update my PR soon

djeck1432 commented 1 week ago

Who we?

Michaelkingsdev commented 1 week ago

Who we?

Typo error ser

Michaelkingsdev commented 1 week ago

@djeck1432 I have updated the PR. Please re-review.

Michaelkingsdev commented 1 week ago

Hello sir @djeck1432 , if i dont modify them, pylint wont pass. Maybe i will share the error i was getting regarding the modified code. I didnt use chatgpt. i made changes according to pylint warnings. I am sorry i should have asked you before doing that.

Michaelkingsdev commented 1 week ago

Hi @djeck1432 I have made the requested changes