search

djeck1432 / spotnet

6 stars 40 forks source link

Add test cases for smart contract #83

Closed djeck1432 closed 3 weeks ago

djeck1432 commented 3 weeks ago
  1. Read guideline here
  2. Set up the project, read README.md how to do that.
  3. Book to help you here
  4. Create test cases for positive and negative scenarios for:
djeck1432 commented 3 weeks ago

@Mystic-Nayy Please, read first guideline

codeZe-us commented 3 weeks ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Mid level Cairo Developer

How I plan on tackling this issue

I like orange

I will set up the contract state with required parameters then invoke the loop_liquidity function with sample deposit data and assert that the position is successfully opened.Also, events like LiquidityLooped will be emitted with correct amounts and token addresses.

PoulavBhowmick03 commented 3 weeks ago

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I'm Poulav Bhowmick, a software engineer at Invisible Studios with a robust background in TypeScript, Rust, Solidity Cairo, fullstack development and blockchain technology. My experience includes building robust applications, optimizing functionalities and blockchain integration. I have actively participated in events and open source contributions, enhancing my capability to tackle real-world tech challenges. My projects can be viewed on my GitHub Profile and OnlyDust Profile. Plus I´m active member of Starknet, Ethereum ecosystem.

How I plan on tackling this issue

I like orange

faurdent commented 3 weeks ago

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

codeZe-us commented 3 weeks ago

!

Okay. I will do that right now

codeZe-us commented 3 weeks ago

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

You did not write test for Deposit

faurdent commented 3 weeks ago

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

You did not write test for Deposit

Check this file, please, it has wrong naming, my bad, but contains tests for Deposit contract

codeZe-us commented 3 weeks ago

Hi @codeZe-us! Before starting, could you please take a look at this pr. It's still under review and I've already introduced some test cases, just so we won't repeat each other. Thanks!

You did not write test for Deposit

Check this file, please, it has wrong naming, my bad, but contains tests for Deposit contract

Yeah,seen. @djeck1432 this task has been done. Should i go ahead with it?

djeck1432 commented 3 weeks ago

@codeZe-us Please ,text me in telegram djeck_vorobey1 and attach this link to this issue in your message

djeck1432 commented 3 weeks ago

Close this issue as duplicated

codeZe-us commented 3 weeks ago

@codeZe-us Please ,text me in telegram djeck_vorobey1 and attach this link to this issue in your message

Ok

codeZe-us commented 3 weeks ago

@codeZe-us Please ,text me in telegram djeck_vorobey1 and attach this link to this issue in your message

Please text me. I can't send you text due to my region/location. CodeZe_us