djeman / android_device_samsung_j3xnlte

20 stars 33 forks source link

Add The Dependencies To The Project #16

Open adrian1234a opened 7 years ago

adrian1234a commented 7 years ago

Hey @djeman you can revise this Please???

djeman commented 7 years ago

Yep when I want ^^

I think you have not tested it because I do not see my repo name. You need to test your modifications ...

An example :

{
    "remote": "github",
    "repository": "djeman/android_kernel_samsung_j3xnlte",
    "target_path": "kernel/samsung/j3xnlte"
}

Twrp omnirom repo not use "cm-13.0" branch but "android-6.0" so maybe there is a setting to choose the branch.

adrian1234a commented 7 years ago

Finish :D

djeman commented 7 years ago

It seems ok but have you try it ?

I need to finish my camera modifications and after I will merge it ;) I make big change when I try to fix a hardware part so it's more easy to me to add it after. I'm on the latest bug of the snap app maybe it's almost finish.

djeman commented 7 years ago

You think it's a good idea to add my repositories in this file ? I fear ^^ I do not see it on all others repo and maybe it's a problem when I'm working on this repo. I launch very often the brunch command and I do not want any sync on my repo.

Edit: I'm always a noob to dev an android OS 🥇 ^^

adrian1234a commented 7 years ago

Ok don't worry

ghost commented 7 years ago

This is a quite useless because dependencies are working only on official supported devices, else it will make something like this in your manifest.xml : "LineageOS/user/android_device_etc...." instead of "user/android_device_etc..."