search

djeraseit / passlib

Automatically exported from code.google.com/p/passlib
Other
0 stars 0 forks source link

Django 1.7 compatibility #53

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
These is a problem in passlib/ext/django/utils.py L189:

Importing _ and SortedDict from django.contrib.auth.hashers is not a good idea 
as it is implementation specific and breaks with Django 1.7 which no longer 
imports SortedDict. By directly importing those from django.utils.translation 
and django.utils.datastructures the code works and should be backwards 
compatible with all Django versions currently targeted by passlib.

I created a pull request on bitbucket for that:

https://bitbucket.org/ecollins/passlib/pull-request/1/fix-django-17-compatibilit
y/diff

Original issue reported on code.google.com by bikeshed...@gmail.com on 4 Dec 2014 at 1:21

GoogleCodeExporter commented 9 years ago 
Thanks for the PR, I've merged it in, and grafted it onto the stable branch as 
well.

My apologies for not responding to this sooner, my day job workload has been 
rather intense. I'm actively trying to devote some time to passlib in the next 
few weeks, and hope to get this out in the new 1.7 release.  If can't find the 
time for that, I'll definitely be making a 1.6.x update very soon to include 
this fix, if nothing else. 

I'm not an active django user myself, so definitely appreciate the pointers and 
maintenance help!

Original comment by elic@astllc.org on 18 Dec 2014 at 8:05