search

djett41 / ionic-content-banner

An informational content banner for Ionic applications
MIT License
84 stars 25 forks source link

banner behind modal #33

Open AgDude opened 8 years ago

AgDude commented 8 years ago

Because the banner is currently inside of ion-content it can't be displayed over the top of a modal. probably needs to go into its own top-level container similar to how ionicLoading works.

johnnyoin commented 8 years ago

Those two commits should do it: https://github.com/johnnyoin/ionic-content-banner/commit/88b0b8dc7cae253adb1ff7c849b06de34f7e8c64 https://github.com/johnnyoin/ionic-content-banner/commit/e1a4b8fb5a44a30382ad299f6a307be9b5f31368

trazek commented 8 years ago

Thanks. Any plan to add this to an updated version?