search

djett41 / ionic-content-banner

An informational content banner for Ionic applications
MIT License
84 stars 25 forks source link

Positioning of the "close" icon #5

Closed pliablepixels closed 9 years ago

pliablepixels commented 9 years ago

Hello, first thanks for this library. It is excellent (and thanks to ionic marketplace, using which I discovered this)

In my app, when I display the banner, the text looks great but the "X" is not aligned properly. I suspect its a CSS conflict with something else as when I tried your demo app in ionic view, it shows up correctly.

I've currently directly edited your JS file and added style="margin-top:-5px" along with the button display where you call ng-close() but I'd prefer to do in a better way if you have any other suggestion.

Screenshot: http://imgur.com/KXq0lSV

Here is how I am adding your CSS and JS files https://github.com/pliablepixels/zmNinja/blob/master/www/index.html

Thanks

pliablepixels commented 9 years ago

I've moved the fix to my stylesheet like this, so I am closing this issue.

.content-banner .content-banner-close
{
    margin-top:-5px;
}
djett41 commented 9 years ago

cool thanks!