search

djett41 / ionic-scroll-sista

An Ionic plugin that hides the header/tabs while scrolling
MIT License
125 stars 38 forks source link

Header unhides when rubber banding past the bottom #20

Open WhatsThatItsPat opened 9 years ago

WhatsThatItsPat commented 9 years ago

This title is pretty self explanatory I think. The header hides as you scroll down the page, but when you scroll past the bottom (or possibly when you reach the bottom) the header comes back. Unintentional movement back toward the top should not bring back the header.

djett41 commented 8 years ago

@patrickmcd Could you explain "Unintentional movement back toward the top should not bring back the header." in a little more detail? Are you saying there is a bug with the current way its implemented? Or are you saying you disagree with the way its implemented?

When scrolling, the header/tabs will animate back in when close to the bottom, which is usually pretty standard especially when you have tabs. It also gets a little complicated when at the bottom and trying to resize content bottom along with tabs offset, so animating back in also helps that scenario

WhatsThatItsPat commented 8 years ago

I would say I disagree with the way it's implemented. It hasn't been my experience that bringing them back would be standard UX.

It works as I would expect in Chrome, as well as in Ionic's own attempt with their header-shrink directive. Using apps like Facebook, you never come across it because they are infinite scrollers, so there's no bottom to hit. I should note I'm only considering iOS, so maybe this implementation is more common on Android. It just seemed off when I was playing with it.

Also, I was only considering using it for my header, so your point is well taken that it makes sense when you have footer tabs. Safari works a bit like that, though it takes a second attempt to scroll past the bottom to bring back the header and the footer tabs.

Rather than considering this an issue report, I guess it's a feature request to have an option for keeping headers hidden when scrolling reaches the bottom.

djett41 commented 8 years ago

Got ya!

It gets a little tricky/buggy if you don't snap back, because you have to readjust the content top/bottom to go back inside the window, which is even more difficult if you have tabs. Not that it cant be done, just something that needs to be figured out.

I agree this should be configurable since not all people will want either option! Theres another issue open for the same so I'll reference

djett41 commented 8 years ago

Related to #23