search

djett41 / ionic-scroll-sista

An Ionic plugin that hides the header/tabs while scrolling
MIT License
125 stars 38 forks source link

Multiple tab sets #9

Closed locrianmode closed 9 years ago

locrianmode commented 9 years ago

I have an application that has a side menu with multiple tab sets, each set displayed when clicking on a menu item.

I found that the scroll-sista directive always refers to the first tab which work. Clicking to display subsequent tab sets will not work.

This is due to the following (line 86 in ionic.scroll.sista.js) , which will always refer to the first tab set. tabs = body.querySelector('.tabs');

Changing to the following works tabs = body.querySelectorAll('.tabs')[body.querySelectorAll('.tabs').length - 1];

djett41 commented 9 years ago

Thanks @locrianmode !!! Works! Just released new verison