Closed chubchenko closed 2 years ago
Please let me know when the PR will be ready 👍
@djezzzl It's ready for review 🎉
Thank you a lot for the contribution!
Could you please say if you have any plans to look at database_validations
and database_consistency
gems? I'm asking to know if I should apply such great improvements by myself or I can count on you 👍
Set up
RuboCop
based on theStandard
rules + fix allRuboCop
issues.Create a separate
rubocop.gemfile
and add it to GemfileAdd
rubocop
job toCircleCI
Correct all layout issues
Use
double-quoted
instead ofsingle
Avoid comma after the last item of a
hash
and anarray
Use
if
instead of emptycase
(Do not use empty case condition, instead use an if expression)Use
$stdout
instead ofSTDOUT
Use safe navigation (
&.
) instead of checking if an object exists before calling the methodAdd frozen string literal comment
Use
other
as a name instead ofcollection
/factory
/trait
Remove unnecessary symbol conversion
Use
caller_locations(2..2).first
instead ofcaller_locations[1]
Move class methods inside a
class << self
blockCheck
block
argument explicitly instead of usingblock_given?
Use
eval_gemfile
instead ofeval