djfoxer / VisualStudioMakeTheSound

Sounds for Visual Studio
MIT License
9 stars 2 forks source link

Breakpoint sound fires on Step while debugging #2

Closed Grifplex closed 4 years ago

Grifplex commented 4 years ago

I thank you for this extension to fill in audio clues where vsDingExtension stopped support at VS 2015. The only thing you extensions falls short is that the Breakpoint sound fires not only when a breakpoint is hit but also when a step action completes. This gets old quickly when rapidly stepping through code. Is there a way to filter out simple steps and only play the sound after running? Thanks, Nick.

djfoxer commented 4 years ago

Thank you for your feedback. I think your suggestion is crucial in that case I will investigate it and try to figure out how to fix it. Also that linked project looks interesting, maybe I will be able to implement something new from that repo.

djfoxer commented 4 years ago

Ok, I think I have found the solution: https://github.com/djfoxer/VisualStudioMakeTheSound/commit/901544c4bf63227949b977b289421a7c93083df2#diff-41794c332f2ee023241c5e8c910a676a Just need more testing

djfoxer commented 4 years ago

Done (PR: https://github.com/djfoxer/VisualStudioMakeTheSound/pull/3) you can check it by downloading new version 0.2.2