search

djfun / audio-visualizer-python

a little GUI tool to render visualization videos of audio files
Other
242 stars 58 forks source link

Relative positioning and dimensions for everything #44

Closed tassaron closed 7 years ago

tassaron commented 7 years ago

Currently changing the output resolution drastically changes the video due to absolute positioning being used by components everywhere. Only the scaling options are relative. If we change all components to use relative positioning, then changing the output resolution will not affect the appearance of the video. Thus someone can export at different resolutions using the same project file.

We should make all components use floats to define their positions as suggested by @IamDH4 in #29. We can use either spinboxes with percentages or sliders in the GUI instead of the current text inputs.

dv-anomaly commented 7 years ago

Just to be clear I think pixel values should still be used in the UI, and the conversion to floats should be handled behind the scenes. With values in the UI updating on a resolution change.

tassaron commented 7 years ago

As of 5784cdbcf87556b61519782cd1fc27065ffbc631, components can define 'relative widgets' which will have their pixel values updated when the resolution is changed. This is applied to every component's x, y, width, height, and font size. So this issue is now closed.