Video component causes inaccurate progress bar

djfun / audio-visualizer-python

a little GUI tool to render visualization videos of audio files

Other

242 stars 58 forks source link

Video component causes inaccurate progress bar #50

Open tassaron opened 7 years ago

tassaron commented 7 years ago

There are a few bugs with the video component that I'm unsure how to fix:

It causes the progress bar to be inaccurate (reaches 99% when it should be around 80%).
~~It eats stdout~~

dv-anomaly commented 7 years ago

Do you know if the bug is present all the way back to the initial implementation?

tassaron commented 7 years ago

Just tested and both bugs are present in the initial implementation (7946e98f222784e25ea9c6dc00713f431e238609).

dv-anomaly commented 7 years ago

Like I said previously I don't have a whole lot of free time through the rest of the month. I will see what I can do next week if this is still in open Bug. I don't see anything obvious at the moment.

tassaron commented 7 years ago

I fixed stdout being eaten, using this from SO.

The progress bar issue continues to elude me. The encoding progress outputted by FFmpeg is accurate, so it's possible the best fix would be to change how we measure the Qt progressbar -- we should use the time output from ffmpeg compared to the expected audio duration, instead of the current method of using the audio frame number. This would make the progress bar accurately represent the progress of ffmpeg instead of the progress of input #0 (the pipe to ffmpeg)