djfun / audio-visualizer-python

a little GUI tool to render visualization videos of audio files
Other
242 stars 58 forks source link

Conway's component does not prevent infinite growth #75

Closed tassaron closed 1 year ago

tassaron commented 2 years ago

Putting an infinite growth pattern into the Conway's Game of Life component will crash while "computing evolution", because there is no limit to stop infinite recursion causing infinite memory usage until the program is killed by the OS

This is a preset that crashes the program if imported into the component:

[Components]
Conway's Game of Life
1
OrderedDict([('GRID', [(6, 4), (6, 5), (6, 8), (7, 4), (7, 7), (8, 4), (8, 7), (8, 8), (9, 6), (10, 4), (10, 6), (10, 7), (10, 8)]), ('color', (85, 0, 127)), ('customImg', False), ('image', ''), ('preset', 'Infinite Growth Crash'), ('scale', 32), ('shadow', False), ('shapeType', 0), ('showGrid', True), ('tickRate', 5)])

I'll fix this myself eventually but if anyone want to help, feel free :)