search

djgroen / FabSim3

Python 3 version of FabSim
BSD 3-Clause "New" or "Revised" License
25 stars 13 forks source link

Add missing import statement for numpy #274

Closed jomichaelis closed 5 months ago

jomichaelis commented 6 months ago

The file fab.py contains a call to np.arrange(..) (here: https://github.com/djgroen/FabSim3/blob/9194ed5dbc3bbb88fe7b917c5158586db8f77fe2/fabsim/base/fab.py#L1337) , however there is no explicit import-statement for numpy. numpy is also not loaded via a from <x> import *.

djgroen commented 6 months ago

@jomichaelis This pull requests seems to break FabSim, so please have another look at it :).

jomichaelis commented 6 months ago

I see, it was just a matter of the location of the import statement. Changed it and isort does not complain anymore.