search

djgroen / FabSim3

Python 3 version of FabSim
BSD 3-Clause "New" or "Revised" License
25 stars 13 forks source link

Integration with RADICAL-Pilot #283

Closed cspgdds closed 4 months ago

arabnejad commented 4 months ago

Hi @cspgdds :grin: just got email for this MR, one comment (I just had a quick look), lower() method returns the lowercase string from the given string so, the PJ_TYPE.lower() variable should be compared with lowercase string

env.PJ_TYPE.lower() == "QCG" should be env.PJ_TYPE.lower() == "qcg"

arabnejad commented 4 months ago

we already load all templates with local_templates_path

why we need to load radical-PJ-py with radical_PJ_py and radical-PJ-headerwith radical_PJ_header variables separately :confused:

cspgdds commented 4 months ago

Accidentally closed it

djgroen commented 4 months ago

we already load all templates with local_templates_path

why we need to load radical-PJ-py with radical_PJ_py and radical-PJ-headerwith radical_PJ_header variables separately 😕

Hi @cspgdds 😁 just got email for this MR, one comment (I just had a quick look), lower() method returns the lowercase string from the given string so, the PJ_TYPE.lower() variable should be compared with lowercase string

env.PJ_TYPE.lower() == "QCG" should be env.PJ_TYPE.lower() == "qcg"

Okay, I think I just resolved this issue whilst typing in a wobbly train. @mzrghorbani @cspgdds please retest as functionality will have been affected by this fix.

Good to hear from you again @arabnejad. Hope life is treating you well! :+1:

djgroen commented 4 months ago

Ok, this is ready for merging :)