search

djgroen / facs

FACS: Flu And Coronavirus Simulator
https://facs.readthedocs.io
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Visit probability more than 1 #55

Open arindamsaha1507 opened 7 months ago

arindamsaha1507 commented 7 months ago

Perhaps the parameters need some tweaking but currently the visit probability in atleast some locations is more than one. This is caught by the error handler here:

https://github.com/djgroen/facs/blob/70d60d8268db241e63b8a2bd85d475042b97a134/facs/base/utils.py#L21

which traces back to

https://github.com/djgroen/facs/blob/70d60d8268db241e63b8a2bd85d475042b97a134/facs/base/location.py#L86

Should I set it to 1 if it is more, or should we change the visit times?

djgroen commented 7 months ago

Hi Arindam,

If it's more than one, then perhaps set the visit probability to 1, but scale up the visit time proportionally for that specific case :).

arindamsaha1507 commented 7 months ago

I have set the probability to 1.

Do you think that scaling should be done for needs or avg_visit_times here?

https://github.com/djgroen/facs/blob/bc0d85d5fe4bc67134fa20c7d0c0d4904d8cc409/facs/base/location.py#L9

I am asking because the raw probability for hospitals is coming out to be 49(!) in some cases. Maybe the needs of some age groups are not proper...

What do you think?

djgroen commented 7 months ago

Hospitalized people will have a 12 hour need for hospitals per day, so that makes sense in that case.

I think scaling up the visit duration for individuals is probably the solution here..?

Cheers, Derek

On Thu, 8 Feb 2024, 15:19 Arindam Saha, @.***> wrote:

I have set the probability to 1.

Do you think that scaling should be done for needs or avg_visit_times here?

https://github.com/djgroen/facs/blob/bc0d85d5fe4bc67134fa20c7d0c0d4904d8cc409/facs/base/location.py#L9

I am asking because the raw probability for hospitals is coming out to be 49(!) in some cases. Maybe the needs of some age groups are not proper...

What do you think?

— Reply to this email directly, view it on GitHub https://github.com/djgroen/facs/issues/55#issuecomment-1934348690, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCMTPJ2F4QUA3BUM2AW6XLYSTUHHAVCNFSM6AAAAABC7N4ZCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZUGM2DQNRZGA . You are receiving this because you were assigned.Message ID: @.***>