search

djgroen / flee

flee agent-based modelling code
BSD 3-Clause "New" or "Revised" License
6 stars 7 forks source link

Add new location definition for IDP camps #60

Closed djgroen closed 1 year ago

djgroen commented 1 year ago

With a default move chance of 1.0

name = "idpcamp"

djgroen commented 1 year ago

I added support for this now. Please test :).

djgroen commented 1 year ago

Relevant commits are: ac6815e91f7be96df2c99c8632661da19f9df530 98eafc37b7a47cc7df98ef4a07c4e558e041c307 90894bf03903e60d59e762705c4a3781f388a872

djgroen commented 1 year ago

@cspgdds Just to let you know: idpcamps are considered camps, which means that they do need a validation CSV file (which can be empty) AND that they can have refugees/population inserted in them on Day 0 in the same way that normal camps have.

Btw. does this feature work well for you and the Columbia team?

cspgdds commented 1 year ago

@djgroen Yes, we are collecting validation CSV files at the moment. Does out.csv record results for all IDP camps? Also, is it possible to add a column for aggregated IDP numbers (i.e., simulation and validation)?

We have not tested it yet, but we plan to test it in the coming week.

djgroen commented 1 year ago

@cspgdds

It does include values for IDP camps, but it will calculate totals and errors aggregated for both refugee and IDP camps in out.csv. I could split this out, but this would result in additional columns containing zeroes for simulations that do not feature IDP camps. Would that be desirable?

cspgdds commented 1 year ago

@djgroen what do you mean by "additional columns containing zeroes for simulations that do not feature IDP camps"?
We would like to compare total IDP counts for simulation and DTM. Also, we might not have validation for all IDP camps to visualise them individually.

cspgdds commented 1 year ago

@djgroen Could you please include a feature in simsetting.yml to add total IDP counts for camps as an additional column within out.csv file?

djgroen commented 1 year ago

This has been added,