djhackersdev / bemanitools

Runs recent Konami arcade games and emulates various arcade hardware.
The Unlicense
79 stars 15 forks source link

Minor texture align issue with IIDX18/19 diagonal texture fix. #100

Open icex2 opened 1 year ago

icex2 commented 1 year ago

In GitLab by @Radio on Sep 18, 2022, 07:59

Summary

Slight texture misalignment happens to various textures resulting in top or bottom parts being slightly cut-off.

Expected behavior

Textures should be properly aligned without cut-off parts.

Current behavior

Some textures are being sliced horizontally on the top or bottom, or perhaps they're misaligned?

Detailed Description

Example from my recent stream, you can clearly see it on the top of the screen on mode select: https://youtu.be/3VPpASrQY10?t=434

Steps to reproduce

  1. Enable diagonal texture fix.

Possible solution

Context (Environment)

Bemanitools version(s) affected

Game(s) and version(s) affected

Log output

See attachment.

Configuration files

See attachment.

Diagonal texture fix enabled.

Command line arguments

APIs used

OS version

Windows 11

Hardware specs

icex2 commented 1 year ago

Can you run the game in window mode and check if the top/bottom of the rendered picture in the window is also showing that? Screenshot for evidence appreciated.

icex2 commented 1 year ago

In GitLab by @Radio on Sep 18, 2022, 19:02

Actually, it seems like you can't see the one on mode select when running windowed without any scaling.

image

But I've found another example, take a look at the stage difficulties here, you can see STAGE 5 being cut-off from the bottom. Also looks like the PASELI text is missing its black outline on the bottom.

image

There's also this that has some values exhibiting the diagonal texture bug, you can see it on the DJ name for example. You can also easily see the SP league level is fine but the DP one is bugged.

image

Edit: I forgot to mention, the videos also have the diagonal seem across them. Sometimes it's hard to notice but it's there.

icex2 commented 1 year ago

That sounds like either the "diagonal texture fix" is not turned on or doesn't work as expected. If you got it turned on, can you turn off and provide screenshots of the screens above for comparison?

icex2 commented 1 year ago

In GitLab by @Radio on Sep 18, 2022, 19:55

Wow I'm sorry for being dumb, those screenshots were indeed without the fix turned on. But now I can actually provide the evidence for mode select misalignment. It should serve as good comparison if nothing else.

image image image image

icex2 commented 1 year ago

Thanks for these. Seems this is not related to the "texture seam fix" at all then. Since it's an "odd gfx" bug again, I guess it's related to some code that worked fine on those x1300 radeon cards (IIRC) just fine. By accident, you don't happen to have another PC with any ATI card?

icex2 commented 1 year ago

In GitLab by @Radio on Sep 19, 2022, 07:14

I actually have the card that can run the games correctly lying around somewhere, I can hook it up and provide screenshots if you really want them. But I've got these that look perfect running on toastertools, hopefully they'll be useful: image image

icex2 commented 1 year ago

That's definintely useful information. So toastertools fixed something else that bemanitools doesn't have, yet. Thanks for the additional references.

JeffPaine4890 commented 1 year ago

Possibly related, Chinese Resort Anthem also has misaligned note beams that I don't get on Japanese Resort Anthem ra-cn