djhackersdev / bemanitools

Runs recent Konami arcade games and emulates various arcade hardware.
The Unlicense
84 stars 16 forks source link

iidxio BIO2 driver backed implementation - [merged] #167

Closed icex2 closed 1 year ago

icex2 commented 3 years ago

Merges iidxio-bio2 -> master

Summary

Implements the iidxio API using the iidxio bio2 driver. This allows you to play any game that supports BT5's iidxio API.

Description

Not a lot to add, summary covers that.

Related Issue

How Has This Been Tested?

Tested on my own cabinet with an original Konami BIO2 from a IIDX 25 PCB + sub IO to hook it up to the C02 wiring of the cabinet.

Checklist

icex2 commented 3 years ago

added 3 commits

Compare with previous version

icex2 commented 3 years ago

added 4 commits

Compare with previous version

icex2 commented 3 years ago

marked this merge request as draft from bf90b20c049d7d9fc614fc761fcd1ec1fca3ed70

icex2 commented 3 years ago

added 1 commit

Compare with previous version

icex2 commented 3 years ago

added 7 commits

Compare with previous version

icex2 commented 3 years ago

added 2 commits

Compare with previous version

icex2 commented 3 years ago

added 1 commit

Compare with previous version

icex2 commented 3 years ago

marked the checklist item Updated existing doc of or add new doc to README file(s). as completed

icex2 commented 3 years ago

marked the checklist item Updated development documentation. as completed

icex2 commented 3 years ago

added 14 commits

Compare with previous version

icex2 commented 3 years ago

marked this merge request as ready

icex2 commented 3 years ago

Updated, moved ViGEm relevant commits to its own MR !68

icex2 commented 3 years ago

added 16 commits

Compare with previous version

icex2 commented 3 years ago

In GitLab by @xyen on Dec 19, 2020, 23:19

Commented on doc/iidxhook/iidxhook9.md line 111

(which is the crucial part for automatic detection). -> (which is the crucial part for the stock game's automatic detection).

icex2 commented 3 years ago

In GitLab by @xyen on Dec 19, 2020, 23:19

Commented on src/main/bio2drv/bi2a-iidx.c line 15

A comment here describing what happens if we use the wrong value would be nice.

icex2 commented 3 years ago

In GitLab by @xyen on Dec 19, 2020, 23:19

Commented on src/main/bio2emu-iidx/bi2a.c line 88

CLEAR -> BIO2_BI2A_CMD_INIT

icex2 commented 3 years ago

In GitLab by @xyen on Dec 19, 2020, 23:22

Commented on src/main/bio2drv/bi2a-iidx.c line 15

nit: better yet move both this one and the one in bi2a-sdvx to the header.

icex2 commented 3 years ago

In GitLab by @xyen on Dec 19, 2020, 23:22

approving aside from some minor changes

icex2 commented 3 years ago

In GitLab by @xyen on Dec 19, 2020, 23:22

approved this merge request

icex2 commented 3 years ago

I wouldn't move that to the header since, at least with current knowledge, this is an implementation detail specific to that usage of the IO, e.g. sdvx vs. iidx. Added clarifying comment because that's a good point.

icex2 commented 3 years ago

changed this line in version 10 of the diff

icex2 commented 3 years ago

changed this line in version 10 of the diff

icex2 commented 3 years ago

added 7 commits

Compare with previous version

icex2 commented 3 years ago

resolved all threads

icex2 commented 3 years ago

added 26 commits

Compare with previous version