aciodrv: Add wavepass support to ICCA (#1) - [merged] #187

Closed icex2 closed 1 year ago

In GitLab by @xyen on Mar 17, 2021, 18:39

Merges aciodrv-wavepass -> master

Summary

Adds wavepass support to aciodrv, eamiotest, and eamio-icca.

Description

Implements wavepass support, while keeping the existing interfaces and slotted reader support.

In order to support the existing interface (which doesn't expose when the game calls the felica poll), as well as support for games that don't natively support wavepass readers, the felica polling of the wavepass reader has been implemented as something that happens automatically every X successful polls. This mirrors how the real games do it.

Related Issue

1

How Has This Been Tested?

Tested with: aciotest / eamiotest:

DDR Slotted: Node 1: type 3, flag 0, version 1.1.0, product ICCA, build date: Oct 26 2005 13:55:03
DDR Slotted: Node 2: type 3, flag 0, version 1.1.0, product ICCA, build date: Oct 26 2005 13:55:03 (tested with just 1, as well as a pair)

aciotest / eamiotest / IIDX10,12,27:

IIDX Wavepass: Node 1: type 3, flag 0, version 1.5.1, product ICCB, build date: Apr 12 2010 09:29:00
IIDX Wavepass: Node 2: type 3, flag 0, version 1.5.1, product ICCB, build date: Apr 12 2010 09:29:00 (IIDX13 errors on card-in, probably issue with how eamio is being used as previously eamio-icca had no use on it)

aciotest / eamiotest / sdvx1-5:

SDVX Wavepass: Node 1: type 3, flag 0, version 1.5.1, product ICCB, build date: Apr 12 2010 09:29:00

aciotest:

Jubeat Wavepass: Node 1: type 3, flag 0, version 1.7.3, product ICCC, build date: Oct 05 2012 20:26:53
Museca Wavepass: Node 2: type 3, flag 0, version 1.7.4, product ICCC, build date: Feb 27 2013 16:44:51

Thanks to:

Cereth for providing me with a slotted and wavepass reader to develop with.
Cammy, Shiz, Grim for testing out the code on a variety of additional readers.

Nit magic number: Create a macro or const field for the value, e.g. #define LOOPS_UNTIL_ICCA_POLL

I think that line can be removed if you assign it just a few lines below based on the actual data.

For debugging, I would add a log_debug outputting how the readers was detected, e.g. slotted vs. wavepass.

Nit: Same as above, move magic number to const field or macro.

I really do like how this turned out. Great job. I will already give you my approval since the things I pointed out are not crucial. Feel free to merge this once my comments are addressed and if you do not disapprove otherwise.

approved this merge request

In GitLab by @xyen on Mar 17, 2021, 22:35

Commented on src/main/eamio-icca/eamio-icca.c line 137

ah, I missed this, it's leftover from when I was testing probably, good catch.

In GitLab by @xyen on Mar 17, 2021, 22:38

resolved all threads

In GitLab by @xyen on Mar 17, 2021, 22:42

Commented on src/main/aciotest/icca.c line 117

changed this line in version 2 of the diff

In GitLab by @xyen on Mar 17, 2021, 22:42

Commented on src/main/eamio-icca/eamio-icca.c line 137

changed this line in version 2 of the diff