WIP: iidxhook/util/settings: Make code more resilient

[icex2]

In GitLab by @icex2 on May 2, 2021, 14:54

WIP branch for working on issue #2

[icex2]

In GitLab by @icex2 on May 2, 2021, 14:55

Looking into this, some personal notes:

• Using @noodle's log file: https://dev.s-ul.net/djhackers/bemanitools/uploads/9a96b9ea165820bc3709215b56c33ec5/log.txt
• Set-up iidx15 with latest btools 5.34 (public release package)
• Default configuration no changes (game boots to fullscreen)
• Booting successful, title screen shows, exiting game
• Comparing to the @noodle's log, I can see that the thread with the id 1502 is spawning the btools iidxhook dll and executing it
• The thread crashing with a stackoverflow is the same thread 1502
• 1502 is the main thread of the game which gets detoured on OpenProcess to init iidxhook of btools
• Address given on stack overflow, 0x6B082103 is inside iidxhook3.dll
• Missing error handling here could cause free of nullptr

[icex2]

In GitLab by @icex2 on May 2, 2021, 15:04

iidxhook3.dll build with fixed error handling in the settings.c module (see commit history of this MR).

[icex2]

In GitLab by @icex2 on May 2, 2021, 20:42

iidxhook3.dll build with additional debug logging in the settings.c module (see commit history of this MR).

[icex2]

In GitLab by @icex2 on May 2, 2021, 20:43

added 1 commit

• f7c7b80f - wip add some debug logging

Compare with previous version

[icex2]

In GitLab by @icex2 on May 9, 2021, 12:14

added 1 commit

• 2d6ada65 - wip skip settings hook, go to next irp

Compare with previous version

[icex2]

In GitLab by @icex2 on Jun 11, 2022, 24:51

Awaited feedback, no response. Closing for now, because unclear if this is even valuable. Can be re-used/re-opened in the future.