aciodrv: add PANB support (+ aciotest handler) - [merged]

[icex2]

In GitLab by @shtokopep on May 2, 2021, 15:16

Merges nostalgia -> master

Summary

add PANB support (nostalgia piano) to aciodrv as well as an aciotest handler for it

Description

this allows to use a nostalgia piano through aciodrv

Related Issue

https://dev.s-ul.net/djhackers/bemanitools/-/issues/69

How Has This Been Tested?

The aciotest handler :

• displays the current velocity of held keys onscreen
• lights pressed keys with that same greenish tone from AC game
• can trigger the device close/reset from a key combination

Checklist

• [x] Implemented (unit) test(s) which prove that the introduced changes are working as expected.
• Tested with the following games: aciodrv cannot be used with the game
• [x] Followed the developer (style) guidelines.
• [x] Updated existing doc of or add new doc to README file(s). aciotest doc didn't provide such level of detail
• [x] Updated development documentation. didn't find aciodrv details in the docs

[icex2]

In GitLab by @xyen on May 3, 2021, 18:28

Commented on src/main/aciodrv-proc/panb.c line 20

it's already a static (above) he just didn't carry over the static declaration down. The rest of the locks and stuff though should also be static.

[icex2]

In GitLab by @xyen on May 3, 2021, 18:28

Commented on src/main/aciodrv-proc/panb.c line 52

Actually, this should be changed thread_create lest we forget later. (it's already bound to crt_thread_create by default).

Having the threads functions be passed in is NOT the solution here I think, it should only be passed when it crosses a memory space boundary, since otherwise the actual IO DLL itself should be receiving the thread functions and calling thread_api_init.

[icex2]

In GitLab by @shtokopep on May 3, 2021, 20:03

resolved all threads

[icex2]

In GitLab by @shtokopep on May 3, 2021, 20:06

Commented on src/main/aciodrv-proc/panb.c line 20

changed this line in version 4 of the diff

[icex2]

In GitLab by @shtokopep on May 3, 2021, 20:06

Commented on src/main/aciodrv-proc/panb.c line 52

changed this line in version 4 of the diff

[icex2]

In GitLab by @shtokopep on May 3, 2021, 20:06

added 1 commit

• 12ab02df - review part 3

Compare with previous version

[icex2]

In GitLab by @shtokopep on May 3, 2021, 20:15

added 4 commits

• 12ab02df...d3026cd5 - 3 commits from branch djhackers:master
• f88ffdb8 - aciodrv: add PANB support (+ aciotest handler)

Compare with previous version

[icex2]

In GitLab by @shtokopep on May 3, 2021, 20:16

Thanks for the feedback, I think I took care of everything, rebased and squashed, should be good to go :)

[icex2]

yeah, that's lgtm. Great first contribution and happy to see others getting on-board.

[icex2]

approved this merge request

[icex2]

resolved all threads