acio: adds definitions for RVOL and MDXF - [merged]

[icex2]

In GitLab by @xyen on Sep 13, 2021, 04:50

_Merges acioddr -> master

Also adds aciodrv / aciotest for RVOL, MDXF is not included as someone else is working on a driver for it already.

[icex2]

In GitLab by @xyen on Sep 13, 2021, 04:51

added 11 commits

• e7af2a7a...78c7d959 - 4 commits from branch master
• 8f46a08e - ddrhook: move common hooks to ddrhook-util
• 5e5daffc - acio: add MDXF node definition
• 0fdd51cd - acioemu: update name of AC_IO_ICCA_CMD_DEVICE_CONTROL
• e6042ade - aciodrv: add method to get product type of node
• 14b75817 - acio: add RVOL node definition
• 346f1d66 - aciotest: add RVOL test, and change to use product types instead of names
• 76eca30e - bio2: add definitions for 20th anniversary model

Compare with previous version

[icex2]

I am not sure here, but afaik this gets filled up automatically to a full byte. However, I would suggest to fill this up with a uint8_t padding : 4 or uint8_t unused : 4

[icex2]

Why 0 and not 0xFFFFFFFF? If both are fine, I would use the latter as it is more noticable in debug output/logs.

[icex2]

    log_assert(device);
    log_assert(pout);

pin optional and null check below.

[icex2]

Just some minor stuff, everything else lgtm. Feel free to merge when addressed and nothing else to clarify.

[icex2]

In GitLab by @xyen on Sep 13, 2021, 22:35

Commented on src/main/acio/mdxf.h line 19

This is in a union, which is why I left it unpadded (the union itself is what provides the raw access if you need the other bits).

[icex2]

In GitLab by @xyen on Sep 13, 2021, 22:35

Commented on src/main/aciodrv/device.c line 399

0 isn't a valid node as far as I know, since product_type is a uint32_t, I don't think -1 makes sense here.

[icex2]

In GitLab by @xyen on Sep 13, 2021, 22:38

added 1 commit

• d05207bd - acio: minor fixes

Compare with previous version

[icex2]

In GitLab by @xyen on Sep 13, 2021, 22:39

resolved all threads