djhackersdev / bemanitools

Runs recent Konami arcade games and emulates various arcade hardware.
The Unlicense
84 stars 16 forks source link

Add additional `avs_net_interface` fields for newer AVS - [merged] #207

Closed icex2 closed 1 year ago

icex2 commented 2 years ago

In GitLab by @Felix on Oct 26, 2021, 01:25

Merges avs-net -> master

Summary

When a blank hardid is provided in the avs2-ea3 configuration, launcher will synthesize one based on the MAC address retrieved via AVS. Unfortunately, this structure expanded in 2.16 and again in 2.17.

Description

Add the additional avs_net_interface fields so AVS does not return an error in ea3_ident_hardid_from_ethernet.

Related Issue

How Has This Been Tested?

I tested this locally with beatmania IIDX 26: Rootage when I was trying to see if 100% usage on a single CPU core was tools related.

Checklist

There were no existing unit tests against AVS functions so I did not add one.

icex2 commented 2 years ago

In GitLab by @xyen on Oct 26, 2021, 01:34

approved this merge request

icex2 commented 2 years ago

In GitLab by @xyen on Oct 26, 2021, 01:44

great catch, lgtm!