sdvxio-kfca and sdvxhook2 updates - [merged] #209

Closed icex2 closed 1 year ago

In GitLab by @xyen on Mar 15, 2022, 08:42

_Merges sdvx_miscupdates -> master

sdvxio-kfca:

adds volume setting when using KFCA (ex: with EAC / when using sdvxhook2)

sdvxhook2:

adds some hooks addressing some system settings that versions of SDVX touch and would be good to avoid

tested locally

What's up with this?

Same here

Nit: Somewhat superfluous, the if-block is very self-explanatory, imo.

What's the impact of this change, considering the return value is a different one now? If none, then I am wondering if the return value is even evaluated correctly.

Nit: The implementation for the volume config values looks to me like a standard way for setting the volume rather than an override as the default is always 0. I would just call it config_kfca.main_volume etc. in the struct and config file instead.

In GitLab by @xyen on Mar 16, 2022, 24:10

Commented on src/main/sdvxio/sdvxio.c line 70

sdvxhook never actually checked the result of this function, and so it succeeded, but other use-cases check the return, and ran into issues when using btools stock sdvxio.