misc. SDVX fixes - [merged]

[icex2]

In GitLab by @xyen on May 20, 2022, 05:54

Merges sdvx-fixes -> master

fixes a crash when using sdvxhook2 on certain OS versions (windows 7 on cabs in particular), and set title pop lights to 50% by default in sdvxio-bio2.

[icex2]

You are checking if the pointer value is > UIN16_MAX? Would expect you want to check the dereferenced value, i.e. *((intptr_t) name) > UINT16_MAX If your code is correct, do you mind explaining why (and maybe add that explanation to the commit message or code as a comment?

[icex2]

In GitLab by @xyen on May 28, 2022, 01:22

Commented on src/main/sdvxhook2/nvapi.c line 36

It's explained right below in the Microsoft doc.

[icex2]

-_-" for not having the full view and seeing the next few lines. lgtm

[icex2]

resolved all threads

[icex2]

approved this merge request

[icex2]

In GitLab by @xyen on May 28, 2022, 01:26

added 3 commits

• 188a14e4 - 1 commit from branch master
• bf805e39 - sdvxio-bio2: set title pop lights to 50% by default
• ccfe6f79 - sdvxhook2: fix crash when using sdvxhook2 on certain OS versions

Compare with previous version