Add support IIDX Resort Anthem CN (狂热节拍 IIDX) - [closed] #222

Closed icex2 closed 1 year ago

In GitLab by @garbage on Jun 12, 2022, 18:13

Merges feature/iidx18-cn -> master

Summary

Support IIDX Resort Anthem CN (狂热节拍 IIDX)

Description

Add support IIDX Resort Anthem CN (狂热节拍 IIDX)

The ID is JDZ, but it is an exe format (not dll).

This game does not have network function

Also, the card reader is not checked, so it is not included in the hooks.

How Has This Been Tested?

By launching and playing the game.

Checklist

[x] Implemented (unit) test(s) which prove that the introduced changes are working as expected.
Tested with the following games:
- [x] Resort Anthem CN
[x] Followed the developer (style) guidelines.
[x] Updated existing doc of or add new doc to README file(s).
[x] Updated development documentation.

In GitLab by @garbage on Jun 12, 2022, 18:48

Commented on src/main/iidxhook4-cn/dllmain.c line 83

3DCG used in the background causes crashing problem with NVIDIA cards.

The same problem with normal IIDX18, but it does not appear to be enabled in iidxhook4.

https://dev.s-ul.net/djhackers/bemanitools/-/blob/master/src/main/iidxhook4/dllmain.c#L61-73

In GitLab by @garbage on Jun 12, 2022, 19:57

added 3 commits

a8c325a3...ece48189 - 2 commits from branch djhackers:master
d899afc6 - Merge remote-tracking branch 'upstream/master' into feature/iidx18-cn

Compare with previous version

In GitLab by @garbage on Jun 12, 2022, 20:01

added 1 commit

d6bc7156 - iidxhook4-cn: add document

Compare with previous version

strstr(lpFileName, PATH_A) == lpFileName) I guess that works also for catching that path equals. Something I haven't seen done that way, yet. Nice learning.

To my knowledge, that doesn't work as "." should be of type const char*. You need to use memcpy, strcpy or initilize the fixed size buffer manually, e.g. relative_path[0] = '.'; relative_path[1] = '\0'.

Same as above, but needs to be considered for wide string type.

Leaving another marker here.

Oh, you are probably right. I apparently missed it there D:

I would say this needs to be added to iidxhook4 and iidxhook5 as it should also affect those games. Would you mind pushing another MR with just these two fixes? Do you happen to have an NVIDIA card where the game is currently crashing and you can test the potential fix?

Since you don't need card readers here, we don't need this linked.

:thumbsup:

As I honstly don't know anything about setting this up, I tossed the iidxhook5-cn.md in there just to have it more like a place holder.

As you have the knowledge on how to set it up and what to consider, do you mind filling in this information here and on iidxhook5-cn.md?

Feel free to copy-paste from the other iidxhook readme files whatever is identical.

Big thanks for looking into this. Probably even more niche than the older games already, but happy someone else is also making an effort to support these older titles.

In GitLab by @xyen on Jun 14, 2022, 02:44

Commented on src/main/iidxhook4-cn/path.c line 80

https://stackoverflow.com/questions/8244453/initializing-char-array-with-smaller-string-literal

ie. it's fine.

In GitLab by @xyen on Jun 14, 2022, 02:44

Commented on src/main/iidxhook4-cn/path.c line 112

see above comment, this is fine.

In GitLab by @xyen on Jun 14, 2022, 02:44

Commented on src/main/iidxhook4-cn/path.c line 139

ditto

Another learning. thanks.

In GitLab by @garbage on Jun 14, 2022, 08:15

Commented on src/main/iidxhook4-cn/Module.mk line 16

changed this line in version 4 of the diff

In GitLab by @garbage on Jun 14, 2022, 08:15

added 1 commit

297c178e - iidxhook4-cn: delete unused libs in Module.mk

Compare with previous version

In GitLab by @garbage on Jun 14, 2022, 08:48

Commented on src/main/iidxhook4-cn/dllmain.c line 83

I pushed MR.

Tested using NVIDIA card with IIDX18.

https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/125

Appreciated for the direct follow-up.

resolved all threads

approved this merge request

Merged in the wrong order, so the current state is conflicting. I pulled the changes and rebased locally to fix the merge conflict. Pushed it to master already, so this is considered merged.

Thanks again.

djhackersdev / bemanitools