Draft: Fix diagonal tearing on IIDX18 and 19 - [closed] #225

Closed icex2 closed 1 year ago

In GitLab by @garbage on Jun 12, 2022, 22:18

Merges feature/diagonal-tearing -> master

Draft as it is not based on master branch

Summary

Fix diagonal tearing on IIDX18 and 19

Description

IIDX18
IIDX18 CN
IIDX19
IIDX20 CN

Ver	Disabled	Enabled
IIDX18
IIDX18CN
IIDX19
IIDX20CN

Maybe

popn 19
popn 20

How Has This Been Tested?

Checklist

[ ] Implemented (unit) test(s) which prove that the introduced changes are working as expected.
Tested with the following games:
- [ ] IIDX18
- [ ] IIDX18 CN
- [ ] IIDX19
- [ ] IIDX20 CN
[ ] Followed the developer (style) guidelines.
[ ] Updated existing doc of or add new doc to README file(s).
[ ] Updated development documentation.

In GitLab by @HAYU on Jun 12, 2022, 22:29

Wow! I thought this was an issue where fix was impossible. If bt5 supports RB in the future, it will be useful for limelight. Great works

In GitLab by @garbage on Jun 13, 2022, 01:32

This issue is also fixed in spicetools with a similar algorithm.

Is there a same problem in RB?

In GitLab by @HAYU on Jun 13, 2022, 03:17

There was the same problem when I ran limelight on ADE-704A (use Radeon E4690 MXM) cab. and I searched and found that Limelight used a PC that uses HD 2400 series. RB 2010 have not been tested, but there is no problem after colette.

In GitLab by @garbage on Jun 13, 2022, 14:20

I see.

You certainly seem to be right.

I have tried with spicetools(since RB is supported) and it seems to fix the problem.

This method will also work when bt5 supports Popn19,20 and RB limelight in the future!

In GitLab by @garbage on Jun 13, 2022, 18:58

resolved all threads

Related issue for reference: https://dev.s-ul.net/djhackers/bemanitools/-/issues/6

Looking at the changeset, it looks like you based your additional changes for fixing the graphical issue on your other branch/MR https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/121 that adds resort anthem CN support. If that applies, you need to edit this MR and change the target branch for now, so we can see the proper changeset in here.

Click on 'Edit' on the top right of the MR page and select your branch from your resort anthem CN as 'into' branch. I think that should do it.

We can swap back the branch to djhackers:bemanitools/master once your resort anthem CN support MR is merged. I suggest we also merge that one first to avoid difficult to resolve conflicts.

This issue is also fixed in spicetools with a similar algorithm.

@garbage

As far as I understand, you based your solution off the one on spicetools. If that is correct, we would kindly ask you check with the original author of that piece of code from spicetools and if they are fine with you porting it over to BT5. It's not a big deal or issue for us and the BT5 project, but we believe it is important to honor the original efforts and contributions on the other project.

To be further clear: We do not discourage copy-pasting of good and working solutions. Just be concious about this and treat the original authors with respect.

In GitLab by @garbage on Jun 14, 2022, 10:49

The algorithm was not my idea, but I also implemented it in spicetools.

So I don't think it's a problem.

In GitLab by @konmai69 on Jun 15, 2022, 12:09

The diagonal tearing issue is also on some PCs when running DDR X1-2014, like my laptop with Radeon Vega 5000 iGPU which has the diagonal tearing and grey hold note bug.

Continuing in https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/126 which fixes the git history.

djhackersdev / bemanitools