search

djhackersdev / bemanitools

Runs recent Konami arcade games and emulates various arcade hardware.
The Unlicense
85 stars 17 forks source link

iidx-irbeat-patch: Rewrite batch files - [closed] #231

Closed icex2 closed 1 year ago

icex2 commented 2 years ago

In GitLab by @PolarManne on Sep 9, 2022, 20:37

Merges master -> master

A dumb little change, it just adds a menu to the .bat files to select the beat phase from instead of specifying it as a parameter, as well as check to make sure it was actually successful.

icex2 commented 2 years ago

Sorry for the late reply, life is keeping me busy.

I like the idea with the menu but in the current state, it removes the ability to run it without the menu, e.g. to use it in other scripts. Can you add this back? One option would be to check the first argument in the beginning of the script and if it is set, skip the menu and run the patch. If not provided, show the menu and proceed after user input.

icex2 commented 2 years ago

In GitLab by @PolarManne on Oct 1, 2022, 18:32

added 1 commit

Compare with previous version

icex2 commented 2 years ago

In GitLab by @PolarManne on Oct 1, 2022, 18:34

Added the ability to do that. It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1. Sorry it took so long to get back, been sick off my ass as of late.

icex2 commented 2 years ago

Added the ability to do that.

Thanks for following up and putting effort into polishing this, appreciated.

It does differ from previous behavior in that it now expects the actual beat number instead of beat number - 1.

I think that's fine and actually makes more sense from a user's perspective. No objections.

Sorry it took so long to get back, been sick off my ass as of late.

No worries, hope you are better now.

icex2 commented 2 years ago

resolved all threads

icex2 commented 2 years ago

approved this merge request

icex2 commented 1 year ago

Sorry for getting back so late about this. I just noticed this one still being open which is odd because I approved it already 2 months ago. No idea why I have not merged this, yet.

Trying to do that now, gitlab just shows me a "Something went wrong. Please try again." error message. It seems like the source branch PolarManne/bemanitools:master does not exist anymore or cannot be accessed (permission issue). If you still want this merged, can you check what might be wrong with your source branch?

@PolarManne

icex2 commented 1 year ago

In GitLab by @PolarManne on Dec 20, 2022, 18:11

It was set to private so probably a permissions issue. I've switched my repo to public so try it again.

icex2 commented 1 year ago

GitLab is being dumb and doesn't allow me to merge this MR anymore. Apparently, it still fights some 404 issues that should not be the case anymore. I opened a new MR, https://dev.s-ul.net/djhackers/bemanitools/-/merge_requests/130, with the changes and appointed you as the author. Merging the other MR and closing this one to conclude this. Thanks again and sorry for the mess.