djhackersdev / bemanitools

Runs recent Konami arcade games and emulates various arcade hardware.
The Unlicense
85 stars 16 forks source link

feat/refactor: bemanitools core, logger, thread #282

Open icex2 opened 8 months ago

icex2 commented 8 months ago

Recommendation to reviewer(s): Review by commit, I added further details and reasoning and tried my best to scope slice and scope the changes.

The main goal of the entire changeset is to refactor two "core" APIs/modules in bemanitools, thread and log(ger). This is, more or less, simply done by moving it out of utils and into a new package named "core". But, the changes furthermore address several issues and limitations that bemanitools has experienced over the last years.

Copy-paste from the "key commit" that adds the new core module with thread and log:

This module contains the "core" (API) of bemanitools which includes an abstraction layer for threads and logging at this time.

The threads API is very close to what util/thread already was with some structural enhancements which make it easier to understand and work with the API, I hope. Some additional helpers (*-ext module) support in doing common tasks, e.g. setting up the thread API with other modules.

The log(ging) part receives a major overhaul to address known limitations and issues with the util/log module:

Additional "extensions" (*-ext modules) add various helper functions for common tasks like setting up the logging engine with a file and stdout sink.

The sinks also improved significantly with the file sink now supporting proper appending and log rotation. Logging to stdout/stderr supports coloring of log messages which works across logging engines.

Overall, this refactored foundation is expected to support future developments and removes known limitations at the current scale of bemanitools such as: