search

djhackersdev / bemanitools

Runs recent Konami arcade games and emulates various arcade hardware.
The Unlicense
85 stars 16 forks source link

Update camhook to support new style camera detection #304

Closed willxinc closed 4 months ago

willxinc commented 4 months ago

This fixes #102 and resolves #90

Tested with a variety of cameras, working: Logitech C922, Logitech StreamCam

Not working Logitech C615

icex2 commented 4 months ago

Not working Logitech C615

Any idea why it is not working? Would be nice if there is a way to test/tell if a cam is compatible.

willxinc commented 4 months ago

Not working Logitech C615

Any idea why it is not working? Would be nice if there is a way to test/tell if a cam is compatible.

Not easily, I bought one to test, will look into it more in a future fix maybe, I suspect it's due to the supported resolution / features.

icex2 commented 4 months ago

Overall, lgtm already regarding the code itself. A few documentation/information related things that I pointed out can be in a follow-up PR. Feel free to merge this once are done cleaning up.

lutzchristoph commented 3 months ago

Can’t get past the Camera check on sdvx-05. Used a Sony ZV-E10 as a streaming device, id: “USB\VID_054C&PID_0DE3&MI_00\9&5B8827E&0&0000” Is it possible to pass this test without a webcam?

willxinc commented 3 months ago

Can’t get past the Camera check on sdvx-05. Used a Sony ZV-E10 as a streaming device, id: “USB\VID_054C&PID_0DE3&MI_00\9&5B8827E&0&0000” Is it possible to pass this test without a webcam?

The changes here are unrelated to SDVX / don't modify the existing camhook behavior, depending on the version it should just skip the camera check. For game-specific support like that I'm not sure this is the best forum for that.