djhackersdev / minime

ALLNET services for newer Sega arcade games
20 stars 3 forks source link

chuni: save and load user course - [closed] #12

Closed icex2 closed 1 year ago

icex2 commented 4 years ago

In GitLab by @NeumPhis on Nov 27, 2019, 18:02

Merges chuni-course -> master

icex2 commented 4 years ago

In GitLab by @tau on Nov 28, 2019, 03:41

Commented on src/chunithm/sql/userCourse.ts line 47

Nit: please insert a line break between these two methods

icex2 commented 4 years ago

In GitLab by @NeumPhis on Nov 28, 2019, 04:05

added 1 commit

Compare with previous version

icex2 commented 4 years ago

In GitLab by @tau on Nov 28, 2019, 04:07

Alright, looks good. I'll merge this as soon as the minor issue with MR !3 is taken care of, since there is a db migration numbering dependency. I'll try to get a CI system set up soon so that Prettier catches minor cosmetic nits like this automatically in the future.

In the meantime can you squash these two commits together?

icex2 commented 4 years ago

In GitLab by @NeumPhis on Nov 28, 2019, 05:00

added 1 commit

Compare with previous version

icex2 commented 4 years ago

In GitLab by @tau on Nov 28, 2019, 17:23

Manually merged after rebase by me.

icex2 commented 4 years ago

In GitLab by @tau on Nov 28, 2019, 17:23

closed