djhackersdev / segatools

Loaders and hardware emulators for SEGA games that run on the Nu and ALLS platforms
The Unlicense
60 stars 7 forks source link

Freshly cloned segatools build process fails at "make dist" #14

Closed icex2 closed 1 year ago

icex2 commented 3 years ago

In GitLab by @coburn64 on Jun 19, 2021, 13:45

Greetings,

When attempting to create a release archive of a locally cloned copy of segatools, during the build process I get the following error which results in the process halting and well... not doing anything productive.

[134/141] Compiling C object mu3hook/mu3hook.dll.p/unity.c.obj
[135/141] Compiling C object mu3hook/mu3hook.dll.p/mu3-dll.c.obj
[136/141] Compiling C object mu3hook/mu3hook.dll.p/dllmain.c.obj
[137/141] Compiling C object mu3hook/mu3hook.dll.p/config.c.obj
[138/141] Compiling C object mu3hook/mu3hook.dll.p/io4.c.obj
[139/141] Compiling C object minihook/minihook.dll.p/dllmain.c.obj
[140/141] Linking target minihook/minihook.dll
[141/141] Linking target mu3hook/mu3hook.dll
... build/zip/chuni.zip
cp: cannot stat 'build/build32/aimeio/aimeio.dll': No such file or directory
cp: cannot stat 'build/build32/chuniio/chuniio.dll': No such file or directory
make: *** [Package.mk:5: build/zip/chuni.zip] Error 1

It seems that aimeio and chuniio don't exist or get excluded from compile, and well... the script fails. Is this an oversight or a unintentional mistake?

icex2 commented 3 years ago

In GitLab by @BemaniWitch on Jun 19, 2021, 17:26

Just tested it, seems to be an oversight. Since the api versioning refactor, the aimeio and HOOKNAMEio.dll's don't exist anymore and instead get built right into the main hook dll. Will put out a merge request to fix this in a bit.

icex2 commented 3 years ago

Fixed with the merge of !37.