search

djhackersdev / segatools

Loaders and hardware emulators for SEGA games that run on the Nu and ALLS platforms
The Unlicense
60 stars 7 forks source link

chunithm new support - [closed] #71

Closed icex2 closed 1 year ago

icex2 commented 2 years ago

In GitLab by @wtl4010 on Oct 27, 2021, 19:12

Merges master -> master

icex2 commented 2 years ago

Hey, I having difficulties understanding this change as you didn't provide a description in the MR nor the commit message. What is this change supposed to achieve? What does "chunithm new support" mean? How have you tested this change? There are a bunch of open questions. We have templates for MRs that guide you to answer these questions.

icex2 commented 2 years ago

In GitLab by @wtl4010 on Oct 27, 2021, 23:48

https://twitter.com/chunithm/status/1450770567104065538 Chunithm New!! is the update for Chunithm Paradise. New PCB(ALLS) with CVT kit.

icex2 commented 2 years ago

In GitLab by @Felix on Oct 28, 2021, 01:21

I cannot accept this as this will break support for older Chunithm.

icex2 commented 2 years ago

In GitLab by @wtl4010 on Oct 28, 2021, 01:26

Sorry. chunihook2?

icex2 commented 2 years ago

In GitLab by @wtl4010 on Oct 28, 2021, 01:33

What about idzhook? Chu3hook is a good name?

icex2 commented 2 years ago

In GitLab by @Felix on Oct 28, 2021, 01:34

Going by the executable name, chusanhook.

icex2 commented 2 years ago

In GitLab by @Felix on Oct 28, 2021, 01:35

chusan is better and idz is for Initial D Zero.

icex2 commented 2 years ago

In GitLab by @rakisaionji on Oct 28, 2021, 11:02

I'm surprised that you guys got the damn DVD before me lol.

I know what you did there Chinese Hackers, ggwp... ( ͡° ͜ʖ ͡°)

image

You supposed to update MiniMe also eh?

And that so little of modification ain't helping anyway. (╯°□°)╯︵ ┻━┻

See chunewhook in my segatools fork for SDGS, that's what it should be.