iccard/felica.c: replace pmm with new, more compatible one - [merged]

[icex2]

In GitLab by @BemaniWitch on Dec 17, 2021, 06:44

_Merges felicafix -> master

Bugfix

Summary

This MR replaces the built in PMM for the felica emulation with a newer, more compatible one.

Description

The old hardcoded PMM only seemed to work for IDZ 1.3 and Chunithm, newer games like Ongeki, IDZ 2.X, and basically every other new ALLS game did not like it, forcing users to switch to the unfinished aime.txt emulation by hand. The new PMM has been taken from my iPhone, which has a virtual suica stored in my apple wallet, which seems to be working with every game i've tested it on.

Related Issue

Verbally discussed issue multiple times. :speech_balloon:

How Has This Been Tested?

Started each game with the old and the new hooks, compared whether or not it would accept said card. Used fresh compiles of the master branch each time.

Checklist

• Tested with the following games:
  • [x] Initial D Arcade Stage Zero V 1.3
  • [x] Initial D Arcade Stage Zero V 2.3
  • [x] Ongeki Summer Plus
• [x] Followed the developer (style) guidelines.
• ~~ Updated existing doc of or add new doc to README file(s)~~
• ~~ Updated development documentation~~

[icex2]

Code change lgtm considering it's very small. I trust your knowledge, judgement and testing on this. +1

[icex2]

approved this merge request

[icex2]

In GitLab by @Felix on Dec 21, 2021, 24:01

approved this merge request

[icex2]

In GitLab by @Felix on Dec 21, 2021, 24:02

Commented on iccard/felica.c line 36

felica -> FeliCa

[icex2]

In GitLab by @Felix on Dec 21, 2021, 24:02

Commented on iccard/felica.c line 35

suica -> Suica

[icex2]

In GitLab by @Felix on Dec 21, 2021, 24:03

Commented on iccard/felica.c line 37

suica -> Suica, probably put "and other payment and transportation cards" instead of "etc"

[icex2]

In GitLab by @BemaniWitch on Dec 21, 2021, 06:24

Commented on iccard/felica.c line 36

changed this line in version 2 of the diff

[icex2]

In GitLab by @BemaniWitch on Dec 21, 2021, 06:24

Commented on iccard/felica.c line 35

changed this line in version 2 of the diff

[icex2]

In GitLab by @BemaniWitch on Dec 21, 2021, 06:24

Commented on iccard/felica.c line 37

changed this line in version 2 of the diff

[icex2]

In GitLab by @BemaniWitch on Dec 21, 2021, 06:24

added 1 commit

• 7c7dbe91 - iccard/felica.c: improve spelling in comment

Compare with previous version

[icex2]

In GitLab by @BemaniWitch on Dec 21, 2021, 06:24

resolved all threads

[icex2]

In GitLab by @BemaniWitch on Dec 21, 2021, 06:26

Went ahead and fixed up the comment a little bit based on Felix's suggestions.

[icex2]

In GitLab by @Sucareto on Jan 16, 2022, 09:13

I have several Amusement IC(Aime) and found that their pmm and system codes are the following values:
pmm=0x00F1000000014300
system_code=0x88B4
Fill idm with random values, can be used in chuni, ongeki, maimai

[icex2]

In GitLab by @BemaniWitch on Jun 18, 2022, 23:27

added 5 commits

• 7c7dbe91...e374c0ab - 3 commits from branch djhackers:master
• 88ddaae4 - iccard/felica.c: replace pmm with new, more compatible one
• fd0f6e23 - iccard/felica.c: improve spelling in comment

Compare with previous version

[icex2]

In GitLab by @tau on Jul 5, 2022, 23:33

I would have preferred this to be a single commit but w/e. Looks fine otherwise, merging.