djhackersdev / segatools

Loaders and hardware emulators for SEGA games that run on the Nu and ALLS platforms
The Unlicense
60 stars 7 forks source link

platform/vfs.c: add nthome for new amdaemon ver - [opened] #76

Open icex2 opened 2 years ago

icex2 commented 2 years ago

In GitLab by @BemaniWitch on Dec 17, 2021, 06:58

_Merges vfsfix -> master

Bugfix

Summary

This MR adds a hook for C:\Users\AppUser to the nthome hook, next to the old C:\Documents And Settings\AppUser hook.

Description

This change is necessary as games newer than IDZ 1.3 and Chunithm have changed said path. Games like IDZ 2.3 will tend to spam a "CANNOT GET ACCOUNTING INFO" error due to the hook not working correctly. This MR fixes said issue and removes the need to run these games as admin.

How Has This Been Tested?

Booted the games up with both the old master version, and the new fixed version, as a standard user instead of admin.

Checklist

icex2 commented 2 years ago

In GitLab by @Felix on Dec 21, 2021, 11:45

The additional global variable for USERPROFILE is not needed. The existing vfs_nthome_real can be used for both the old-style and new-style user profile path replacement.

icex2 commented 2 years ago

In GitLab by @BemaniWitch on Dec 21, 2021, 13:40

added 1 commit

Compare with previous version

icex2 commented 2 years ago

In GitLab by @BemaniWitch on Dec 21, 2021, 13:40

Good point, fixed.

icex2 commented 2 years ago

In GitLab by @BemaniWitch on Dec 21, 2021, 13:40

resolved all threads

icex2 commented 2 years ago

In GitLab by @BemaniWitch on Jun 18, 2022, 23:27

added 5 commits

Compare with previous version

icex2 commented 2 years ago

In GitLab by @tau on Jul 5, 2022, 23:32

I wasn't attentive enough when the Option path hook was added, I don't like how we have three mostly-identical path hook functions here. Can you factor out the common code into a helper function and then call that from each hook instead? Or perhaps even better make a single hook that is table-driven.

icex2 commented 2 years ago

In GitLab by @BemaniWitch on Jul 5, 2022, 23:36

Good call I think. I‘ll see what I can do.