search

djhenderson / pefile

Automatically exported from code.google.com/p/pefile
Other
0 stars 0 forks source link

set_bytes_at_rva has impropper exception handleing #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Call set_bytes_at_rva with an invalid RVA

What is the expected output? What do you see instead?
It would expect to see an legitimate exception thrown. Instead, the code 
executes "raise False" which throws a TypeError because raise takes an object 
that inherits from BasicException.

What version of the product are you using? On what operating system?
1.2.10-102 on windows and linux

Original issue reported on code.google.com by jwert...@gmail.com on 28 Apr 2011 at 3:26

GoogleCodeExporter commented 9 years ago

Original comment by ero.carr...@gmail.com on 29 Apr 2011 at 9:34

GoogleCodeExporter commented 9 years ago 
Correct. It should return False and not raise False. I will fix it. 

Thanks for reporting the problem.

Original comment by ero.carr...@gmail.com on 4 May 2011 at 9:33

GoogleCodeExporter commented 9 years ago 
Fixed in revision 107

Original comment by ero.carr...@gmail.com on 5 May 2011 at 5:26