dji-sdk / DJIWidget

The DJIWidget is a delightful DJI library includes VideoPreviewer for video decoding.
Other
36 stars 30 forks source link

Xcode warnings when building for Device (not sim) #12

Open logancautrell opened 5 years ago

logancautrell commented 5 years ago

We are seeing these warnings when building for device.

screen shot 2018-11-06 at 4 44 42 pm
DJIRtmpMuxer.m:964:58: warning: values of type 'OSStatus' should not be used as format arguments; add an explicit cast to 'int' instead [-Wformat]
                                NSLog(@"start audio queue failed %d, disable audio", status);
                                                                 ~~                  ^~~~~~
                                                                 %d                  (int)
1 warning generated.

DJIImageCalibrateHelper.o

DJIImageCalibrateHelper.m:112:95: warning: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Wformat]
        NSString* workHash = [NSString stringWithFormat:@"image.calibrate(%ld).working.queue",self.hash];
                                                                          ~~~                 ^~~~~~~~~
                                                                          %lu                 (unsigned long)
DJIImageCalibrateHelper.m:122:94: warning: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Wformat]
        NSString* rendHash = [NSString stringWithFormat:@"image.calibrate(%ld).render.queue",self.hash];
                                                                          ~~~                ^~~~~~~~~
                                                                          %lu                (unsigned long)
2 warnings generated.
dji-dev commented 5 years ago

Hi @logancautrell , DJIWidget is not a standalone library, you need to use it with DJI iOS SDK: https://github.com/dji-sdk/Mobile-SDK-iOS, have you try to use Cocoapods to install DJIWidget in your Xcode project?

logancautrell commented 5 years ago

We manually embed both DJISDK and DJIUXSDK in our project currently.

My concern here is that the warnings are indicating potential bugs in the Widget codebase.