search

dji-sdk / DJIWidget

The DJIWidget is a delightful DJI library includes VideoPreviewer for video decoding.
Other
35 stars 30 forks source link

remove xcconfig 'VALID_ARCHS' #23

Open lacklock opened 3 years ago

lacklock commented 3 years ago

On Xcode 12 ‘VALID_ARCHS’ is deprecated，should replace with ‘EXCLUDED_ARCHS’。

DJI-MSDK is working fine。

image

dji-dev commented 3 years ago

Agent comment from Luce Luo in Zendesk ticket #39280:

Dear Customer,

Thank you for contacting DJI. Sorry, I'm not sure it's clear for me. Can you please show me a screenshot or more detail where the VALID_ARCHS configured in Widger?

Thanks,

Luce Luo DJI Developer Support

lacklock commented 3 years ago

image On Xcode12 ‘VALID_ARCHS’ will cause build error of swift project.

dji-dev commented 3 years ago

Agent comment from Luce Luo in Zendesk ticket #39280:

Dear Customer,

Thank you for contacting DJI. I see, will escalate this issue to the engineer.

Thanks,

Luce Luo DJI Developer Support

lacklock commented 3 years ago

image Replace it to this： s.xcconfig = { 'EXCLUDED_ARCHS' => 'i386', 'ONLY_ACTIVE_ARCH' => 'YES'}

mauron85 commented 3 years ago

On Xcode 12.1 when you don't remove that VALID_ARCHS, widget won't build for Simulator. More info here https://stackoverflow.com/questions/63607158/xcode-12-building-for-ios-simulator-but-linking-in-object-file-built-for-ios

And solution here:

https://stackoverflow.com/a/63714000/3896616